-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: assign missed deprecation code #26492
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
Issues and PRs related to the stream subsystem.
label
Mar 7, 2019
CI: https://ci.nodejs.org/job/node-test-pull-request/21300/ Please 👍 this comment to approve fast-tracking. |
addaleax
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
fast-track
PRs that do not need to wait for 48 hours to land.
and removed
stream
Issues and PRs related to the stream subsystem.
labels
Mar 7, 2019
BridgeAR
approved these changes
Mar 7, 2019
gireeshpunathil
approved these changes
Mar 7, 2019
richardlau
approved these changes
Mar 7, 2019
cjihrig
approved these changes
Mar 7, 2019
Landed in 76e67e9 |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecations
Issues and PRs related to deprecations.
fast-track
PRs that do not need to wait for 48 hours to land.
lib / src
Issues and PRs related to general changes in the lib or src directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #26245
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes